Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polishing #532

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Polishing #532

merged 5 commits into from
Sep 18, 2024

Conversation

janosg
Copy link
Member

@janosg janosg commented Sep 13, 2024 •
edited
Loading

  • Add more detailed Python version classifiers (needed for badge in README)
  • Make processing of NAG result object compatible with newest DFO-LS
  • Merge pre-commit autoupdate
  • Update tutorial on optimization

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/estimagic/__init__.py 96.36% <100.00%> (ø)
src/estimagic/bootstrap.py 99.06% <100.00%> (ø)
src/estimagic/bootstrap_outcomes.py 100.00% <100.00%> (ø)
src/estimagic/estimate_ml.py 82.47% <100.00%> (ø)
src/estimagic/estimate_msm.py 89.68% <100.00%> (ø)
src/estimagic/estimation_table.py 84.33% <100.00%> (-0.04%) ⬇️
src/estimagic/examples/logit.py 96.96% <ø> (ø)
src/estimagic/lollipop_plot.py 100.00% <ø> (ø)
src/estimagic/ml_covs.py 84.14% <100.00%> (ø)
src/estimagic/msm_covs.py 100.00% <100.00%> (ø)
... and 4 more

@janosg janosg requested a review from timmens September 17, 2024 13:40
timmens
timmens approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@janosg janosg merged commit 42fd8a5 into main Sep 18, 2024
14 checks passed
@janosg janosg deleted the polishing branch September 18, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmens timmens timmens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janosg @timmens